remove Plausible Analytics metions from CE #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
force-pushed
the
remove-plausible-analytics-mentions-in-ce
branch
from
fec178e
to
aaf191f
Compare
ruslandoga
commented
May 23, 2024
| @@ -47,9 +47,11 @@ | |||
| <% end %> | |||
| <%= @inner_content %> | |||
|
|
|||
| <p class="text-center text-gray-500 text-xs py-8"> | |||
| © <%= DateTime.utc_now().year() %> Plausible Analytics. All rights reserved. | |||
| </p> | |||
There was a problem hiding this comment.
Here's how CE looks without it:
| </p> | ||
| <%= if ee?() do %> | ||
| <p class="text-center text-gray-500 text-xs py-8"> | ||
| © <%= DateTime.utc_now().year() %> Plausible Analytics. All rights reserved. |
There was a problem hiding this comment.
© is kept in the EE build:
| @@ -1,6 +1,6 @@ | |||
| <div class="mt-12 w-full md:max-w-xl md:mx-auto bg-white dark:bg-gray-800 md:shadow-md md:rounded px-8 py-6"> | |||
| <p class="text-gray-900 text-xl font-black dark:text-gray-100"> | |||
| Welcome to Plausible Analytics! | |||
| Welcome to Plausible! | |||
ruslandoga
commented
May 23, 2024
| issuer: @issuer_name | ||
| ) | ||
| issuer_name = Plausible.product_name() | ||
| NimbleTOTP.otpauth_uri("#{issuer_name}:#{user.email}", user.totp_secret, issuer: issuer_name) |
There was a problem hiding this comment.
It should be OK: https://g.co/gemini/share/3806579d87a0
The v2.1.0-rc users who created TOTP secrets with issuer=Plausible Analytics shouldn't encounter any issues with this change. The new TOTP secrets would be issued by Plausible CE.
|
@ruslandoga merge at will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes some of Plausible Analytics mentions from CE builds. There are still places where this mention is kept:
analytics/assets/js/app.js
Line 108 in 23a6431
analytics/lib/plausible_web/controllers/stats_controller.ex
Line 381 in 23a6431
analytics/lib/plausible_web/templates/layout/_footer.html.heex
Line 23 in 23a6431
analytics/lib/plausible_web/templates/page/index.html.eex
Line 6 in 23a6431
Tests
Changelog
Documentation
Dark mode